Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Bad words falling if message is empty #22930

Merged
merged 8 commits into from
Aug 20, 2021

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 13, 2021

Issue(s)

In some places like Ominichannel channels creation was failing if the bad words is activated.
sendMessage(guest, { t: 'livechat-started', msg: '', groupable: false }, room);

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team August 13, 2021 22:37
@sampaiodiego sampaiodiego added this to the 3.17.1 milestone Aug 16, 2021
@sampaiodiego sampaiodiego removed this from the 3.17.1 milestone Aug 16, 2021
@Shailesh351
Copy link
Contributor

Reverting back to bad-words version 3.0.3 worked for me.

In the bad-words repo some users have reported similar issue for other cases as well. Like adding ":)" or "[" also causes the similar issue.

web-mech/badwords#103 web-mech/badwords#95

So, IMO it's better to use current stable version "bad-words": "3.0.3",

@ggazzo ggazzo requested a review from sampaiodiego August 20, 2021 03:22
@sampaiodiego sampaiodiego merged commit ac7ae55 into develop Aug 20, 2021
@sampaiodiego sampaiodiego deleted the fix/bad-words-filtering branch August 20, 2021 21:06
@sampaiodiego sampaiodiego mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants